Correct nullability annotations in OIDEndSessionRequest #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…postLogoutRedirectURL, state
|
@philet have you signed the contributor agreements? |
|
@petea I have signed them last Friday. Probably still needs to be processed on your side. |
|
@philet confirmed that we have the needed documentation from you, thanks. |
petea
changed the title
|
Since this will be a breaking change for the Swift interface, we'll need to make it as part of a major release. |
|
@petea since its only adding the nullability won't existing code still compile meaning its not a breaking change? |
|
We're having to run a fork of this lib because of this issue. Is there anything missing from the PR that we could provide? |
xeniabeckel
approved these changes
Jan 30, 2023
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct nullability annotations for
OIDEndSessionRequestparametersidTokenHint,postLogoutRedirectURL, andstate.Fixes #565